Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for Zoom Meetings, --check-activity #483

Merged
merged 3 commits into from Feb 14, 2024

Conversation

amadotejada
Copy link
Contributor

If active Zoom meetings are detected, the script will exit. No user dialogs are shown. This handles scenarios when we run the script remotely via MDM tools in alternative to the Self-Service method, I think it's ideal to only display dialog prompts to users when they are not in Zoom meetings, Apple Silicon, password prompt, etc. Other video conference solutions could also be added.

If active Zoom meetings are detected, the script will exit. No user dialogs are shown.
@grahampugh
Copy link
Owner

Hi, thanks for the PR, it's an interesting idea. A couple of points:

  • functions are in their own part of the script (and mostly in alphabetical order), not inline with the main script body.
  • I would not expect a different function for each possible variety of video communication app, so I think the parameter label should be more generic. Something like --check-active-meetings or --check-activity (could include PowerPoint etc if that's possible).

- rename to --check-activity
- moved function and in alphabetical order
@amadotejada
Copy link
Contributor Author

Hello @grahampugh,

Thanks for your points. I've done the following.

  • renamed to --check-activity
  • moved function and in alphabetical order

@amadotejada amadotejada changed the title added --check-zoom Check for Zoom Meetings, --check-activity Feb 11, 2024
@grahampugh
Copy link
Owner

Thanks, there's one error but I'll merge it in and make the change myself.

@grahampugh grahampugh merged commit 311d0d2 into grahampugh:33.0 Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants