Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard nil HeadObjectOutput fields #17

Merged
merged 3 commits into from
May 2, 2020

Conversation

jcharum
Copy link
Contributor

@jcharum jcharum commented Apr 30, 2020

See #14 (comment) for context.

file/s3file/s3file.go Outdated Show resolved Hide resolved
@jcharum
Copy link
Contributor Author

jcharum commented Apr 30, 2020

@josh-newman: Could you take another look? I applied the same guards to (*s3Impl).Stat, refactoring along the way.

file/s3file/s3file.go Outdated Show resolved Hide resolved
file/s3file/s3file.go Outdated Show resolved Hide resolved
@jcharum jcharum merged commit ec89c5f into grailbio:master May 2, 2020
@jcharum jcharum deleted the stat-nil-output-fields branch May 2, 2020 02:10
@tatatodd
Copy link

tatatodd commented May 2, 2020

Thanks very much folks for the fix!

If it's easy, can you create a v0.0.8 release at some point? We'll use a commit hash in our go.mod in the meantime, but it'd be nice to be on a tagged release. :)

@jcharum
Copy link
Contributor Author

jcharum commented May 2, 2020

If it's easy, can you create a v0.0.8 release at some point?

https://github.com/grailbio/base/releases/tag/v0.0.8

@tatatodd
Copy link

tatatodd commented May 2, 2020

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants