GPHIB-18: Upgrade ehcache dependency to 2.9.0 #6
Conversation
|
Upgrading to 2.8.1 caused various test failures https://travis-ci.org/grails-plugins/grails-hibernate4-plugin/builds/27287652 It doesn't seem the cache factory implementation is compatible? |
candrews
changed the title
|
@graemerocher I've updated this pull request. All tests pass and it seems to work nicely. The build is currently failing because the master build is failing due to this commit: 3a59907 |
|
Just rebased and re-ran all the tests to ensure this patch still works. It's ready to merge. |
candrews
changed the title
|
Just updated the pull request for ehcache 2.8.4 |
…egionFactory The tests rely on there being exactly one unnamed cache. Earlier versions of EhCache are more tolerant and will reuse an existing unnamed cache if an attempt is made to create another unnamed cache (or an attempt is made to create another named cache with the same name), but later versions will throw an exception. By using SingletonEhCacheProvider, the same cache is always used, which is what earlier versions of EhCache do anyways, and prevents problems with later versions.
candrews
changed the title
|
Just rebased - still ready for merging. |
|
Craig has asked that we either accept or reject this so until one of us can take a closer look and do some testing I will go ahead and reject it. Thanks for your help. |
GPHIB-18: Upgrade ehcache dependency to 2.9.0
Upgrade the ehcache dependency to 2.8.1.