cache getParameterTypes call

grails · Jan 27, 2014 · 07467ea · 07467ea
1 parent 3c69f18
commit 07467ea
Showing 1 changed file with 9 additions and 12 deletions.
diff --git a/...ls-core/src/main/groovy/org/codehaus/groovy/grails/commons/metaclass/BaseApiProvider.java b/...ls-core/src/main/groovy/org/codehaus/groovy/grails/commons/metaclass/BaseApiProvider.java
@@ -35,7 +35,7 @@
  */
 public abstract class BaseApiProvider {
 
-    private static List<String> EXCLUDED_METHODS = Arrays.asList("setMetaClass", "getMetaClass");
+    private static List<String> EXCLUDED_METHODS = Arrays.asList("setMetaClass", "getMetaClass", "setProperties", "getProperties");
 
     public static final String CONSTRUCTOR_METHOD = "initialize";
     public static final String CTOR_GROOVY_METHOD = "<ctor>";
@@ -71,16 +71,22 @@ public void addApi(final Object apiInstance) {
                 }
                 else {
                     instanceMethods.add(new ReflectionMetaMethod(new CachedMethod(javaMethod)) {
+                        {
+                            CachedClass[] paramTypes = super.getParameterTypes();
+                            if(paramTypes.length > 0) {
+                                setParametersTypes((CachedClass[]) ArrayUtils.subarray(paramTypes, 1, paramTypes.length));
+                            }
+                        }
+
                         @Override
                         public String getName() {
-
                             String methodName = super.getName();
                             if (isConstructorCallMethod(javaMethod)) {
                                 return CTOR_GROOVY_METHOD;
                             }
                             return methodName;
                         }
-
+                        
                         @Override
                         public Object invoke(Object object, Object[] arguments) {
                             if (arguments.length == 0) {
@@ -97,15 +103,6 @@ private Object[] checkForGStrings(Object[] arguments) {
                             }
                             return arguments;
                         }
-
-                        @Override
-                        public CachedClass[] getParameterTypes() {
-                            final CachedClass[] paramTypes = method.getParameterTypes();
-                            if (paramTypes.length > 0) {
-                                return (CachedClass[]) ArrayUtils.subarray(paramTypes, 1, paramTypes.length);
-                            }
-                            return paramTypes;
-                        }
                     });
                 }
             }