GRAILS-8978: Respect grails.views.gsp.htmlcodec configuration

[candrews]

Commit 5037e65 intended for the grails.views.gsp.htmlcodec setting to take effect. This commit fixes the implementation so that setting is respected.

https://jira.grails.org/browse/GRAILS-8978

[graemerocher]

what was the motivation in using the static holder version rather than GrailsApplicationAware?

[candrews]

@graemerocher the setGrailsApplication method is never called. It appears that GrailsApplicationAware doesn't work for this case (I'm not sure if that's intentional or not, but I did confirm that this codec is the only one that tries to use GrailsApplicationAware).

[osscontributor]

is HTMLCodec being subjected to DI? I think GrailsApplicationAware would cause the property to be auto initialized if the thing were a bean in the context. I don't think that is the case, or is it?

[candrews]

When I debugged through it, it didn't appear to be a bean. I suspect that it's not and not intended to be one which explains why GrailsApplicationAware/setGrailsApplication isn't executed.

In that case, I think either some changes need to be made making it a bean or an approach such as the one in this PR needs to be used.

[graemerocher]

The correct fix would be get it to honour GrailsApplicationAware, we try to avoid the use of the statics going forward

[osscontributor]

DefaultCodecLookup is already a bean in the application context and it is already GrailsApplicationAware. It might end up being really simple to add code there which initializes the grailsApplication property in the codecs.

[candrews]

DefaultCodecLookup tries to perform injection on the codec class in DefaultCodecLookup.autowireCodecBean. However, grailsApplication is null, so it never actually does anything.
DefaultCodecLookup.grailsApplication comes from AbstractGrailsClass (DefaultCodecLookup extends AbstractGrailsClass). It looks like AbstractGrailsClass.setGrailsApplication(GrailsApplication) should be called, but is called too late.
The problem is in DefaultGrailsApplication.addArtefact

grails-core/grails-core/src/main/groovy/org/codehaus/groovy/grails/commons/DefaultGrailsApplication.java

Line 775 in 2ac245a

GrailsClass artefactGrailsClass = handler.newArtefactClass(artefactClass);

handler.newArtefactClass(artefactClass) creates the codec instance, but it doesn't have the grailsApplication until the next line, which is too late.

[candrews]

All set - IMHO, this PR is ready for merging.

I created a simple Grails app to test that the grails.views.gsp.htmlcodec setting takes effect, and it does.

The PR includes updates to the tests to test this functionality.

[osscontributor]

Thanks Craig. We will take a look.

[candrews]

Polite prodding

It would be super cool to get this merged - let me know if there's anything I can do to help.