Resolution of GRAILS-11583 - removing of web flow param settings #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove additional parameters are added for grails web flow
Ideally we need to take out urlAttrs.params = params from createLink operation as webFlow plugin already takes care of adding execution param.
This reverts commit 805c406.
This reverts commit d134872.
This reverts commit af9f1c8.
This reverts commit 4735566.
Removed duplicate web-flow key mapping attribute from 2.4.x fields in order to provide options to users for having flexibility to avoid execution params
Merged
|
@vinod2800 You should squash these commits into one. You can do this for example like this: |
graemerocher
added a commit
that referenced
this pull request
Mar 23, 2015
Resolution of GRAILS-11583 - removing of web flow param settings
|
g:link event="something" does not carry "execution" parameter anymore... see my comment on commit 5328b20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prob - While using grails webflow, it's adding additional "execution=e1s1" query string to URL
Resolution - removed "urlAttrs.params = params" mapping ( https://github.com/grails/grails-core/blob/v2.4.4/grails-plugin-gsp/src/main/groovy/org/codehaus/groovy/grails/plugins/web/taglib/ApplicationTagLib.groovy#L363) line as it's duplicate place.
grails-web-flow-plugin 2.1.0 - has code to handle execution=e1s1, parameter if you need to bookmark or share the pages.
Thank You,
Vinod