fix(build): Cleanup dependency management #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All dependencies were declared with the api scope which is not necessary and which leaks dependencies to downstream projects. After this change it should no longer be necessary for Grails apps to force the version of groovy-xml. Several unused dependencies have also been removed.
|
@puneetbehl I have now tested this pull request on https://github.com/grails/grails-functional-tests by:
And the build runs without issues. I have also previously successfully built https://github.com/grails/grails-spring-security-core (which also has several grails apps for testing) with these changes. In this project there is also code in |
Project depends on grails-bootstrap and grails-gradle-model. These were previously transitive dependencies pulled in by grails-shell but as classes from them are used in the project they should be declared.
matrei
added a commit
to matrei/grails-forge
that referenced
this pull request
Feb 1, 2024
This configuration is no longer necessary as the groovy-xml version no longer leaks from the gradle-gradle-plugin (via grails-bootstrap and grails-shell). Related: grails/grails-gradle-plugin#273
puneetbehl
pushed a commit
to grails/grails-forge
that referenced
this pull request
Feb 2, 2024
This configuration is no longer necessary as the groovy-xml version no longer leaks from the gradle-gradle-plugin (via grails-bootstrap and grails-shell). Related: grails/grails-gradle-plugin#273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All dependencies were declared with the api scope which is not necessary and which leaks dependencies to downstream projects. After this change it should no longer be necessary for Grails apps to force the version of groovy-xml. Several unused dependencies have also been removed.