Create new Compiler Task that can be Forked from Gradle #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s huge performance issues when compiling a large amount of classes. This is now forked using the GroovyPageCompilerForkTask...grails PR to follow
|
Might want to cleanup the commented out code. If it is not necessary anymore it shouldn't be there |
|
Agreed, I was waiting to be sure you guys were ok with removing the debug logs as the fork seems to output ALL logs |
… to compile...Fixed issues in Forked Compiler...Removed need to write to temporary directory groovy files reducing I/O
|
Added Multithreaded support with a ThreadPool...Improved compile time performance by ~40% |
|
@davydotcom I am not sure if I understand why the debug logs are removed? Does it print all logs irrespective of the Logger configuration? Personally, I find logs very helpful while debugging. Thanks! |
|
yes it does...this is why grails-views also has no Logger use because a forked config tends to do that. Also several of these arent really needed. |
… of threads. This reduces stack memory overhead by a large margin
…ore efficient on iterative things like token parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GSP Still uses ANT inside the groovy daemon for compiling. This causes huge performance issues when compiling a large amount of classes. This is now forked using the GroovyPageCompilerForkTask...grails PR to follow"
[patch-forked-compile-task 943c2aa] GSP Still uses ANT inside the groovy daemon for compiling. This causes huge performance issues when compiling a large amount of classes. This is now forked using the GroovyPageCompilerForkTask...grails PR to follow