Partially fixes grails/grails-core#11450 . The PersistentEntity getId… #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entity() property is null for a composite key. This skips the rendering of the identity if it is null. However, it does not render the properties either since they are not considered persistentProperties(). It is recommended to use a custom marshaller as Composite keys, though supported, are not recommmended as per the documentation. Also updated project to gradle 6.5
… to frequent outages
|
I don't see this module getting another release. Converters is not included with the latest Grails 3.3 and was considered deprecated then. |
|
People still use grails 3.3. and grails 3.3 is not EOL and it has a bug. I definitely think it should get another release. |
|
This PR was modified to flag |
…being phased out" This reverts commit 0fa91be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes grails/grails-core#11450 . The PersistentEntity getIdentity() property is null for a composite key. This skips the rendering of the identity if it is null. However, it does not render the properties either since they are not considered persistentProperties(). It is recommended to use a custom marshaller as Composite keys, though supported, are not recommmended as per the documentation. Also updated project to gradle 6.5