Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stdlib: Reintroduce sin, cos, tan, gamma, factorial functions #1478

Open
spotandjake opened this issue Nov 12, 2022 · 1 comment
Open

Stdlib: Reintroduce sin, cos, tan, gamma, factorial functions #1478

spotandjake opened this issue Nov 12, 2022 · 1 comment
Assignees

Comments

@spotandjake
Copy link
Member

spotandjake commented Nov 12, 2022

Currently our trig functions in the module library such as Number.sin, Number.cos and Number.tan have some issues. That we should correct, we should make an attempt either fully improve the implementation for a more accurate function or create fast paths for special angles that would allow for more accuracy. Another current problem is with how we map values into the a -pi and pi range. as we dont have arbitrary precision floats we lose accuracy which makes the trig functions almost useless with bigints.

Edit Note: The original issue misidentified the problem we were running into, Upon furthur investigation there seems to be some other issues, so I hijacked this issue for that.

@spotandjake spotandjake changed the title Stdlib: Make Number.sin Unbounded Stdlib: Improve Number trig functions Feb 13, 2024
@phated phated changed the title Stdlib: Improve Number trig functions Stdlib: Reintroduce sin, cos, tan, gamma, factorial functions Feb 22, 2024
@phated
Copy link
Member

phated commented Feb 22, 2024

I updated the title since we're removing these in #2046 until the correct fix is made.

@spotandjake spotandjake self-assigned this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants