fix(stdlib)!: Add a lookup table to Numbr.sin to improve trig accuracy
#2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
ospencer,
phated,
peblair,
marcusroberts and
jozanza
as code owners
ospencer
reviewed
Feb 21, 2024
phated
requested changes
Feb 22, 2024
There was a problem hiding this comment.
I don't like this hack. @spotandjake can you fix these correctly by the next community meeting? Otherwise I think we back out the broken math functions for the release
|
Closing this as @spotandjake says he won't be able to implement the full fix before v0.6. Instead, we are removing the functions (which is breaking) so we can re-add them as a non-breaking feature with the full fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a lookup table to the
sinfunction which increases the accuracy ofsin,cosandtantechnically this is breaking as our results are going to be different.This isn't a long term solution as if we are not using a special angle there is still some inaccuracy, especially as numbers get larger.
work for: #1478