fix(compiler): Don't trigger recompilation for unnecessary compiler flags #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
requested review from
phated,
marcusroberts,
peblair,
jozanza and
alex-snezhko
as code owners
marcusroberts
approved these changes
May 7, 2024
compiler/src/utils/config.re
Outdated
| @@ -1,3 +1,6 @@ | |||
| // Digestable configurations are ones that affect Grain object files. | |||
| // Any config options that don't change object files should be marked | |||
| // NotDigestable to avoid unnecessary recompiles | |||
| type digestable = | |||
| | Digestable | |||
compiler/src/utils/config.re
Outdated
| @@ -353,17 +360,24 @@ let stdlib_dir = | |||
| ~conv=option_conv(Cmdliner.Arg.string), | |||
| ~doc="Path to the standard library (stdlib) directory", | |||
| ~env="GRAIN_STDLIB", | |||
| ~digestable=Digestable, | |||
There was a problem hiding this comment.
Could you remind me why the stdlib option would be Digestable but include_dirs is not?
There was a problem hiding this comment.
It doesn't need to be, good catch.
|
@alex-snezhko Made those changes. |
alex-snezhko
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.