-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler): Don't trigger recompilation for unnecessary compiler flags #2106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval from me, I did my best to decide if your digestable/notdigestable was correct, but trust you on it!
compiler/src/utils/config.re
Outdated
@@ -1,3 +1,6 @@ | |||
// Digestable configurations are ones that affect Grain object files. | |||
// Any config options that don't change object files should be marked | |||
// NotDigestable to avoid unnecessary recompiles | |||
type digestable = | |||
| Digestable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit typo on digestible
compiler/src/utils/config.re
Outdated
@@ -353,17 +360,24 @@ let stdlib_dir = | |||
~conv=option_conv(Cmdliner.Arg.string), | |||
~doc="Path to the standard library (stdlib) directory", | |||
~env="GRAIN_STDLIB", | |||
~digestable=Digestable, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remind me why the stdlib option would be Digestable
but include_dirs is not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't need to be, good catch.
@alex-snezhko Made those changes. |
No description provided.