Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List functions #141

Merged
merged 11 commits into from
Jun 1, 2020
Merged

List functions #141

merged 11 commits into from
Jun 1, 2020

Conversation

JacobGinsparg
Copy link
Contributor

Adding functions to stdlib.List for #94

@ospencer ospencer self-assigned this May 31, 2020
ospencer
ospencer reviewed May 31, 2020
View reviewed changes
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good! Left some comments/suggestions. Let me know your thoughts.

compiler/test/stdlib/lists.test.gr Outdated Show resolved Hide resolved
compiler/test/stdlib/lists.test.gr Show resolved Hide resolved
compiler/test/stdlib/lists.test.gr Show resolved Hide resolved
compiler/test/stdlib/lists.test.gr Show resolved Hide resolved
stdlib/lists.gr Outdated Show resolved Hide resolved
stdlib/lists.gr Outdated Show resolved Hide resolved
stdlib/lists.gr Outdated Show resolved Hide resolved
stdlib/lists.gr Show resolved Hide resolved
stdlib/lists.gr Outdated Show resolved Hide resolved
stdlib/lists.gr

let rotate = (n, l) => {
let (beginning, end) = if (n >= 0) part(n, l) else part(length(l) + n, l)
append(end, beginning)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

ospencer
ospencer approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@ospencer ospencer merged commit d43d962 into grain-lang:master Jun 1, 2020
@JacobGinsparg JacobGinsparg mentioned this pull request Jun 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ospencer ospencer ospencer approved these changes

Assignees

@ospencer ospencer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JacobGinsparg @ospencer