Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #63
I believe the last thing holding up the OCaml upgrade was reason-language-server not support >4.8, but with #180 we are now recommending OCaml Platform/OCaml LSP as the tooling for working on the compiler.
The only real change was that the Misc module in compiler-libs no longer contains
may
andmay_map
because Option is in the stdlib now. Ref ocaml/ocaml#8692