feat(compiler)!: Update include syntax #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
requested review from
peblair,
jozanza,
phated and
marcusroberts
as code owners
ospencer
force-pushed
the
oscar/include-syntax
branch
2 times, most recently
from
8bf2415
to
89db187
Compare
ospencer
force-pushed
the
oscar/include-syntax
branch
from
89db187
to
67c4c02
Compare
phated
requested changes
Feb 22, 2024
There was a problem hiding this comment.
Found a few things. The big one is non-punning of as when the include is the same.
@ospencer Also, in the root issue you mentioned the LSP does an inlay for the module name, so you'll need to fix that as well. I think it just needs to be changed from : ModuleName to include ModuleName
This was referenced Feb 22, 2024
phated
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2001