Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Properly escape quoted strings in toString/print #670

Merged
merged 1 commit into from
May 29, 2021
Merged

fix: Properly escape quoted strings in toString/print #670

merged 1 commit into from
May 29, 2021

Conversation

ospencer
Copy link
Member

@ospencer ospencer commented May 25, 2021 •
edited

feat: Support \b, \f, \t, and \v escapes
fix: Fix parsing of '\'' char literal

Fixes #669

@ospencer
fix: Properly escape quoted strings in toString/print
a5c77d5 
feat: Support \b, \f, \t, and \v escapes
fix: Fix parsing of '\'' char literal
@ospencer ospencer requested a review from a team May 25, 2021 00:05
@ospencer ospencer self-assigned this May 25, 2021
@ospencer ospencer mentioned this pull request May 25, 2021
Closed
phated
phated approved these changes May 29, 2021
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! And nice cleanup on that old code ❤️

@ospencer ospencer merged commit c5d3e44 into main May 29, 2021
@ospencer ospencer deleted the fix-quoted-strings branch May 29, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

@marcusroberts marcusroberts marcusroberts approved these changes

Assignees

@ospencer ospencer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quoted strings should be escaped
3 participants
@ospencer @phated @marcusroberts