Recalculate Trigger for Model GH component #258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenkasirer
reviewed
Jun 24, 2024
chenkasirer
reviewed
Jul 2, 2024
| @@ -24,6 +24,9 @@ | |||
|
|
|||
|
|
|||
| class ModelComponent(component): | |||
| def __init__(self): | |||
| self.model = TimberModel() | |||
There was a problem hiding this comment.
wouldn't this just create an empty TimberModel every time the component is run? shouldn't the beams and joint etc. be added anyways (even if geometry is not calculated)
There was a problem hiding this comment.
I added this so that every the model would persist, even if the inputs changed. I don't know of another way to do this.
There was a problem hiding this comment.
Ok the other way would be to have the Scene be persistent/instantiated in the __init__(). I think we would then loose a lot of the speed improvements that we would otherwise gain from this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to trigger CreateGeometry on the CT_Model GH component. The component will mostly function as before, except that when the CreateGeometry input parameter is set to False, it maintains the last geometry created, instead of reverting to
beam.blanks. This allows the user to use a button input to trigger a recalculation of the geometry, which is useful when dealing with large models where each parameter change would otherwise trigger a new solution.We could consider adding a reset button if it turns out users want to look at the
beam.blankstoo.What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas_timber.datastructures.Beam.