Initialize tables on first load in forms #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- forms.db and necessary tables (analytics and forms) need to be created before forms app can be used. - /configure will test for database and table (forms) and create tables (forms, analytics) if necessary. - scheduler creates database and tables (forms, analytics) on startup. Without this, forms app wouldn't work.
- remove create_form_tables utility that uses queries - introduce formhandler columns-based table creation for `analytics` and `forms` tables - downstream impact: update data-source for `.formhandler()` in form.html - disable mouse events while previewing the form at `/form/id`
|
@sanand0 updated the PR, kindly review |
28 tasks
bkamapantula
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
forms.db and analytics, forms tables need to be created before forms app can be used.
Solution
analyticsandformstables.formhandler()in form.html/form/idWithout this, forms app wouldn't work.