Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix webpack tree shacking (add lens json side effect) #65

Merged
merged 1 commit into from
Dec 27, 2019
Merged

Fix webpack tree shacking (add lens json side effect) #65

merged 1 commit into from
Dec 27, 2019

Conversation

A-gambit
Copy link
Member

@A-gambit A-gambit commented Dec 27, 2019 •
edited

Webpack production mode ignores unused import. So we don't add needed methods to Lens object. To fix it we need to add a sideEffect on importing of json module.

blacktaxi
blacktaxi approved these changes Dec 27, 2019
View reviewed changes
Copy link
Member

@blacktaxi blacktaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blacktaxi blacktaxi merged commit 281b70f into master Dec 27, 2019
@blacktaxi blacktaxi deleted the fix-tree-shaking branch December 27, 2019 17:42
@drakosvlad drakosvlad mentioned this pull request Jan 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blacktaxi blacktaxi blacktaxi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@A-gambit @blacktaxi