Fix tree-shaking #77
Merged
Fix tree-shaking #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After migrating to the Focal version 0.8.1, I have got the same error as in issue #66. It turned out that the reason was that the effectful module
lens/json.jsdid not make it to the production bundle becausesideEffectswere set tofalseinpackage.json. However, thesideEffectsupdate in the MR #65 did not fix the problem, and the module was still not included in the bundle. I have found that we also need to add thelens/index.jsmodule to thesideEffectsforlens/json.jsmodule to appear in the production build.After adding this module to the
sideEffectsfield, thelens/jsonmodule is added to the bundle and the.key is not a functionerror does not happen anymore.