Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Atom/Lens-only version to focal-atom #72

Merged
merged 32 commits into from
Apr 5, 2023

Conversation

oleksiilevzhynskyi
Copy link
Collaborator

@oleksiilevzhynskyi oleksiilevzhynskyi commented Jun 16, 2020

Context

The Focal project ties together the state management logic and API for React integration. However, in some cases, React integration is redundant and brings uneccesarry dependencies to the project.

Well, the goal is to move the state management in a separate package to use it in non-React applications.

Implementation details

Overall, It's a second attempt to move Atom/Lens-only version into a separate package.

This MR split focal into two packages:

  • @grammarly/focal-atom - contains only atoms/lenses-related code, without any dependency on React.
  • @grammarly/focal keeps the same interface but depends on @focal-atom - no breaking changes here.

Limitations:

  • to simplify version management, both packages release under the same version (https://github.com/facebook/react/releases releasing this way)
  • to avoid cracking changes packages @grammarly/focal has a explicit dependency on @grammarly/focal-atom (^0.9.0)

Resolves #68

@oleksiilevzhynskyi oleksiilevzhynskyi self-assigned this Apr 4, 2021
@oleksiilevzhynskyi oleksiilevzhynskyi requested review from KatSick and removed request for Wenqer April 3, 2023 11:09
Copy link
Collaborator

@KatSick KatSick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no feedback to provide at this time. However, we should consider testing new packages with alpha versions before fully releasing them.

@oleksiilevzhynskyi
Copy link
Collaborator Author

@KatSick thank you! I'm going to bump the minor version and publish it as alpha - 0.10.0-alpha

@oleksiilevzhynskyi oleksiilevzhynskyi merged commit d5184bb into master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish Atom/Lens-only version
4 participants