-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Atom/Lens-only version to focal-atom #72
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksiilevzhynskyi
force-pushed
the
feature-focal-state-2
branch
from
September 9, 2022 13:19
242efd2
to
0e5b0e6
Compare
…changes for the existing projects
oleksiilevzhynskyi
requested review from
blacktaxi,
Wenqer and
andrei-zhidkov
February 27, 2023 09:02
KatSick
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no feedback to provide at this time. However, we should consider testing new packages with alpha versions before fully releasing them.
@KatSick thank you! I'm going to bump the minor version and publish it as alpha - 0.10.0-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The Focal project ties together the state management logic and API for React integration. However, in some cases, React integration is redundant and brings uneccesarry dependencies to the project.
Well, the goal is to move the state management in a separate package to use it in non-React applications.
Implementation details
Overall, It's a second attempt to move Atom/Lens-only version into a separate package.
This MR split focal into two packages:
Limitations:
Resolves #68