fix: avoid mapped type during filter query type narrowing #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnorpelSenf
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
==========================================
- Coverage 46.08% 46.07% -0.01%
==========================================
Files 19 19
Lines 6052 6051 -1
Branches 320 318 -2
==========================================
- Hits 2789 2788 -1
Misses 3260 3260
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Closed
|
@all-contributors add @kolay-v for review |
|
@kolay-v already contributed before to review |
|
Oh |
|
Awesome |
rojvv
reviewed
May 13, 2024
| if (ctx.callbackQuery) { | ||
| const s: string = ctx.update.callback_query.data; | ||
| assert(s); | ||
| throw "never"; |
There was a problem hiding this comment.
Perhaps you could replace this and other instances of it with https://deno.land/std@0.224.0/assert/unreachable.ts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mapped type
AliasPropsprevents us from leveraging the improvements in microsoft/TypeScript#57871. Hence, even though microsoft/TypeScript#57863 was fixed as a consequence of #543, we are still seeing problems like #551 appear usingtypescript@next.This PQ removes the helper type and inlines its functionality into the existing collection of
Shortcuts. In addition to fixing #551, this removes complexity and improves consistency. However, it reduces code reuse a little bit, which is acceptable.You can only test these changes on Node, since Deno does not ship with
typescript@nextyet, which you need to install. You can try out these changes withnpm install github:grammyjs/grammY#avoid-mapped-typeas usual.Closes #551.