Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document roziscoding/grammy-autoquote #441

Merged
merged 17 commits into from
Aug 22, 2022
Merged

Document roziscoding/grammy-autoquote #441

merged 17 commits into from
Aug 22, 2022

Conversation

roziscoding
Copy link
Contributor

I used google translate for spanish and chinese translations as I don't speak anny of those languages, so it's okay if they need to be replaced by actual translations

@KnorpelSenf
Copy link
Member

It is not necessary to provide machine translations. We would like to have accurate translations written by native or near-native speakers. Feel free to remove these files again, they serve no purpose.

Other contributors will take care of the translations as soon as the English version is approved by the website maintainer.

@KnorpelSenf KnorpelSenf requested a review from rojvv July 21, 2022 21:36
@roziscoding
Copy link
Contributor Author

Okay. Should I also remove the entries for the other languages from the navbar?

@KnorpelSenf
Copy link
Member

You can leave empty entries there for the translators to fill out if you want

@roziscoding
docs: remove bad translation pages
153b68b 
The links were also removed since I can't really translate the plugin
name well
@KnorpelSenf
Copy link
Member

Please run the formatting script according to the README to fix CI :)
https://github.com/grammyjs/website#checking-correct-formatting-of-docs

@roziscoding
Copy link
Contributor Author

I did 🤔
But I'll do it again, anyways

@roziscoding
Copy link
Contributor Author

image

Does deno fmt only check changed files or something? Or maybe is the deno version on the CI different from my version (1.24.0)?

@rojvv
Copy link
Member

rojvv commented Jul 24, 2022

@roziscoding yep, you should upgrade:

deno upgrade

@roziscoding
Copy link
Contributor Author

roziscoding commented Jul 24, 2022 •
edited
Loading

I'm already on 1.24.0 (which deno upgrade says is the latest version)

Though running it again did fix stuff...

@roziscoding @rojvv
Update site/docs/plugins/autoquote.md
e51f607 
Co-authored-by: Roj <rojserbest@gmail.com>
quadratz
quadratz requested changes Jul 25, 2022
View reviewed changes
site/docs/plugins/autoquote.md Outdated Show resolved Hide resolved
site/docs/plugins/autoquote.md Outdated Show resolved Hide resolved
quadratz
quadratz requested changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@quadratz quadratz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title case

site/docs/plugins/autoquote.md Outdated Show resolved Hide resolved
site/docs/plugins/autoquote.md Outdated Show resolved Hide resolved
KnorpelSenf
KnorpelSenf requested changes Jul 25, 2022
View reviewed changes
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed I have a few more nitpicks, but otherwise this LGTM.

@roj1512 should the third-party modules be sorted chronologically or alphabetically?

site/docs/plugins/autoquote.md Outdated Show resolved Hide resolved
site/docs/plugins/autoquote.md Outdated Show resolved Hide resolved
site/docs/plugins/autoquote.md Outdated Show resolved Hide resolved
@rojvv
Copy link
Member

rojvv commented Jul 25, 2022

@KnorpelSenf We decide on that later

@KnorpelSenf
Copy link
Member

In other words, chronologically until we decide to reorder?

@rojvv
Copy link
Member

rojvv commented Jul 25, 2022

Yes, until we start deciding to reorder after merging this

@KnorpelSenf
Copy link
Member

Does that mean this is ready for translation?

@rojvv
Copy link
Member

rojvv commented Jul 29, 2022

No, not without your suggestions being applied.

@KnorpelSenf
Copy link
Member

@roziscoding I took the liberty to fix up the examples

@KnorpelSenf KnorpelSenf requested a review from rojvv July 29, 2022 13:30
@roziscoding
Copy link
Contributor Author

image

@rojvv
Copy link
Member

rojvv commented Aug 6, 2022

AHAHAH. Darlene's brother.

@rojvv rojvv removed the ready for translation Translator intervention is required. label Aug 6, 2022
@rojvv rojvv changed the title Add section about the Autoquote plugin Document roziscoding/grammy-autoquote Aug 6, 2022
@rojvv rojvv added the ready for translation Translator intervention is required. label Aug 6, 2022
@quadratz quadratz mentioned this pull request Aug 6, 2022
Closed
58 tasks
quadratz
quadratz requested changes Aug 6, 2022
View reviewed changes
site/docs/plugins/autoquote.md Outdated Show resolved Hide resolved
site/docs/plugins/autoquote.md Outdated Show resolved Hide resolved
@quadratz
Copy link
Contributor

quadratz commented Aug 6, 2022

Hmm.. orange?!

21312dsads

quadratz
quadratz requested changes Aug 6, 2022
View reviewed changes
Copy link
Contributor

@quadratz quadratz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the orange background in the code snippets.

site/docs/plugins/autoquote.md Outdated Show resolved Hide resolved
site/docs/plugins/autoquote.md Outdated Show resolved Hide resolved
site/docs/plugins/autoquote.md Outdated Show resolved Hide resolved
quadratz
quadratz requested changes Aug 6, 2022
View reviewed changes
site/docs/plugins/autoquote.md Outdated Show resolved Hide resolved
site/docs/plugins/autoquote.md Outdated Show resolved Hide resolved
site/docs/plugins/autoquote.md Outdated Show resolved Hide resolved
quadratz
quadratz requested changes Aug 6, 2022
View reviewed changes
Copy link
Contributor

@quadratz quadratz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add grammy_autoquote to modules.json

@rojvv
Copy link
Member

rojvv commented Aug 6, 2022

Thanks @CikiMomogi.

@roziscoding
Apply suggestions from code review
5b26f2a 
Co-authored-by: Ciki Momogi <git.fytyt@aleeas.com>
@quadratz
Copy link
Contributor

Add grammy_autoquote to modules.json

@roziscoding

@roziscoding
Copy link
Contributor Author

Add grammy_autoquote to modules.json

@roziscoding

Done!

WingLim
WingLim requested changes Aug 20, 2022
View reviewed changes
Copy link
Collaborator

@WingLim WingLim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shoud use the same format for plugin summary

site/docs/plugins/autoquote.md Outdated Show resolved Hide resolved
roziscoding and others added 2 commits August 20, 2022 12:05
@WingLim WingLim added the 🇨🇳 ZH Modifies or is related to the Chinese translations. label Aug 20, 2022
@rojvv rojvv changed the base branch from main to autoquote August 22, 2022 11:56
@rojvv rojvv merged commit feb1c04 into grammyjs:autoquote Aug 22, 2022
rojvv added a commit that referenced this pull request Aug 22, 2022
@rojvv @KnorpelSenf
@roziscoding @habemuscode
Document roziscoding/grammy-autoquote (#441) (#482)
92563ba 
Co-authored-by: Ciki Momogi <git.fytyt@aleeas.com>
Co-authored-by: WingLim <643089849@qq.com>
Co-authored-by: Rogerio Jurado Munhoz <rogerio.munhoz@macbook-will130867.local>
Co-authored-by: KnorpelSenf <shtrog@gmail.com>
Co-authored-by: Roj <ez@roj.im>
Co-authored-by: Roz <3948961+roziscoding@users.noreply.github.com>
Co-authored-by: Habemuscode <habemuscode@protonmail.com>
PonomareVlad added a commit that referenced this pull request Jun 27, 2023
@PonomareVlad
Reducing import from web path for Cloudflare Workers following #441
4b835de
PonomareVlad added a commit that referenced this pull request Oct 14, 2023
@PonomareVlad
Reducing import from web path for Cloudflare Workers following #441
dc2e7e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WingLim WingLim WingLim requested changes

@KnorpelSenf KnorpelSenf KnorpelSenf approved these changes

@rojvv rojvv rojvv approved these changes

@quadratz quadratz quadratz approved these changes

Assignees
No one assigned
Labels
🇨🇳 ZH Modifies or is related to the Chinese translations. ready for translation Translator intervention is required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@roziscoding @KnorpelSenf @rojvv @quadratz @WingLim