Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error reporting is null on the client side. #17

Closed
jlengstorf opened this issue Oct 16, 2017 · 0 comments · Fixed by #20
Closed

Error reporting is null on the client side. #17

jlengstorf opened this issue Oct 16, 2017 · 0 comments · Fixed by #20
Labels
bug

Comments

@jlengstorf
Copy link
Member

Whenever an error happens in a query, the log is correct on the server, but shows up null on the client side.
@jlengstorf jlengstorf added the bug label Oct 16, 2017
jlengstorf added a commit that referenced this issue Oct 16, 2017
@jlengstorf
fix(errors): restore client-side bugs
bd9671d 
- Pre-call formatError with a logger to avoid confusion. This is important, because I confused myself and spent two hours accusing the Apollo team of changing the API before I realized what I’d done.

- Improved error reporting for GraphQL core error (e.g. syntax errors). Messages are no longer swallowed on the client side.

fix #17
jlengstorf added a commit that referenced this issue Oct 16, 2017
@jlengstorf
test(errors): add test coverage
05f38a2 
re #17
@jlengstorf jlengstorf mentioned this issue Oct 16, 2017
Merged
jlengstorf added a commit that referenced this issue Oct 16, 2017
@jlengstorf
fix(errors): restore client-side bugs
814554c 
- Pre-call formatError with a logger to avoid confusion. This is important, because I confused myself and spent two hours accusing the Apollo team of changing the API before I realized what I’d done.

- Improved error reporting for GraphQL core error (e.g. syntax errors). Messages are no longer swallowed on the client side.

fix #17
jlengstorf added a commit that referenced this issue Oct 16, 2017
@jlengstorf
test(errors): add test coverage
19ea92b 
re #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(error): restore client error output gramps-graphql/gramps-express
1 participant
@jlengstorf