Implement place formats #368
Conversation
Nick-Hall
force-pushed
the
place-format
branch
2 times, most recently
from
fa9dc2c
to
0caa8ae
Compare
Codecov Report
@@ Coverage Diff @@
## maintenance/gramps50 #368 +/- ##
========================================================
- Coverage 42.35% 42.34% -0.02%
========================================================
Files 1064 1065 +1
Lines 141991 142191 +200
========================================================
+ Hits 60144 60210 +66
- Misses 81847 81981 +134
Continue to review full report at Codecov.
|
|
Only had a quick look and found it can be accessed from the Edit>Preferences>Display tab and that the Places tab has been removed. Pictures for the rest of you:
Selecting the Edit button from above brings this up.
Entries in the drop down list. Would it make sense to have the initial "Full" entry as a read only default that's common for all user? |
Yes. I'll make it read-only. |
|
Hi |
|
Since you mention the development in version, I assume you must have a git
clone of the Gramps Repository.
If so it is pretty easy. From your Gramps repository root,
git checkout -b Nick-Hall-place-format mastergit pull
https://github.com/Nick-Hall/gramps.git place-format
The first line creates a new git 'branch' in your local repo.
The second line fetches the whole set of changes that Nick has done.
When you start the development version of Gramps, you are then running
off of Nicks work.
When done, you can switch back to master version with
git checkout master
If you want to test with the Gramps 4.2 branch, it is quite a bit more
difficult.
I personally use 'git worktree' (read up about it) to set up another view
into my local repo.
And then I set up a hardlink with the windows mklink command between the
'gramps' subdirectory of the repo in the worktree and the corresponding
'gramps' subdirectory in the AIO.
You need to use git in the worktree base directory to
git checkout maintenance/gramps42
That should get you the latest Gramps 42 files running on your AIO.
But getting the PR to run on the AIO requires 'cherry-picking' the commits
from Nick repo (or your local git copy) into a new branch based off of the
gramps42 in the worktree. You will want to read up about this before
attempting. I will also warn you that with the number of changes between
Nicks work, master, and gramps42, there will likely be a lot of merge
conflicts which are not always easy to clean up.
I don't know your experience level, if you are pretty new to this I would
wait until this becomes available in a Gramps 4.2.x version (if it ever
does, not likely since we don't do 'enhancements' to maintenance branches).
Good luck
Paul Culley
…On Mar 31, 2017 12:33 PM, "uli22" ***@***.***> wrote:
Hi
can anybody give me an advice how I could download all those files and
apply the changes to my gramps AIO or development version in one go. Is
that possible or do I have to exchange every single file?
thanks
Uli
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#368 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ARSF20qeoQcIpstFtaOWIXHA6pppijzOks5rrTjZgaJpZM4Mq072>
.
|
|
Thank you for this useful enhancement! |
|
@Nick-Hall The travis build on this failed a while ago, should we wait to test this or is it ok? |
|
@daleathan Thanks. It probably just needs a rebase. |
|
@Nick-Hall Looks like a bunch of test failing all related to place. |
Nick-Hall
force-pushed
the
place-format
branch
from
a7e94d0
to
61da620
Compare
Nick-Hall
changed the title
Nick-Hall
force-pushed
the
place-format
branch
from
61da620
to
1f31521
Compare
Nick-Hall
force-pushed
the
place-format
branch
from
1f31521
to
cbac988
Compare
|
|
@sam-m888 Thanks for adding the images. I have updated the text. |
|
@Nick-Hall Thank you
…On 16 February 2018 at 02:55, Nick Hall ***@***.***> wrote:
@sam-m888 <https://github.com/sam-m888> Thanks for adding the images. I
have updated the text.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#368 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIguKdIerUP-ar2CsxTBIwEiIQ8-b6Pzks5tVFNkgaJpZM4Mq072>
.
|
I'm not completely happy with this yet.
The editor has a new field called "levels". It allows users to select hierarchy levels in the place loosely based on the python string slicing syntax. A number of colon ranges can be specified in a comma-separated list. "0" represents the lowest level - typically a building or street. "-1" represents the highest level - typically a country. The populated place is represented as "p".
For example:
"p:" = Populated place upwards.
"p,-1" = Populated place and country.