Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug11151 Fix Language update_po.py to scan for XML fragments in Python files. #826

Merged
merged 2 commits into from Jun 15, 2019

Conversation

prculley
Copy link
Contributor

@prculley prculley commented Jun 13, 2019

The GEPS044 updated uimanager work included a bunch of XML fragments as strings embedded in the Python files. Unfortunately I did not realize that these would not be found by the standard xgettext utility.

I've updated our update_po script to scan for these fragments, searching for translatable strings, and adding them to the gramps.pot.

In the process I discovered a number of cases where I was attempting to translate (via the XML fragments) already translated strings. The second commit corrects that (and updates gramps.pot).

Thanks to our Finnish translator "niememat" who spotted this issue.

@prculley prculley added the bug label Jun 13, 2019
@codecov-io
Copy link

codecov-io commented Jun 13, 2019

Codecov Report

Merging #826 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #826   +/-   ##
=======================================
  Coverage   41.96%   41.96%           
=======================================
  Files        1066     1066           
  Lines      144760   144760           
=======================================
  Hits        60751    60751           
  Misses      84009    84009
Impacted Files Coverage Δ
gramps/plugins/view/citationtreeview.py 0% <ø> (ø) ⬆️
gramps/plugins/view/repoview.py 0% <ø> (ø) ⬆️
gramps/plugins/view/geofamily.py 0% <ø> (ø) ⬆️
gramps/gui/views/tags.py 0% <ø> (ø) ⬆️
gramps/plugins/lib/libpersonview.py 0% <ø> (ø) ⬆️
gramps/plugins/view/eventview.py 0% <ø> (ø) ⬆️
gramps/plugins/view/familyview.py 0% <ø> (ø) ⬆️
gramps/gui/views/navigationview.py 0% <ø> (ø) ⬆️
gramps/gui/displaystate.py 0% <ø> (ø) ⬆️
gramps/gui/plug/quick/_quickreports.py 13.63% <ø> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81a1b67...6d67dff. Read the comment docs.

@sam-m888 sam-m888 added this to the v5.1 milestone Jun 14, 2019
@sam-m888 sam-m888 changed the title Bug11151 Fix Language updoate_po.py to scan for XML fragments in Python files. Bug11151 Fix Language update_po.py to scan for XML fragments in Python files. Jun 14, 2019
@Nick-Hall Nick-Hall merged commit 6d67dff into gramps-project:master Jun 15, 2019
Nick-Hall added a commit that referenced this pull request Jun 15, 2019
@prculley prculley deleted the bug11151 branch June 15, 2019 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants