Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix improper escaping in odt output for TOC/Bookmark etc. #928

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

prculley
Copy link
Contributor

@prculley prculley commented Oct 5, 2019

Fixes #11378

For the index, toc, bookmark etc. normal XML escape is correct, the original code also added sub-tags for line break and tab which was NOT correct.

@prculley prculley added the bug label Oct 5, 2019
@codecov-io
Copy link

Codecov Report

Merging #928 into maintenance/gramps51 will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           maintenance/gramps51     #928   +/-   ##
=====================================================
  Coverage                 41.94%   41.94%           
=====================================================
  Files                      1066     1066           
  Lines                    144948   144948           
=====================================================
  Hits                      60805    60805           
  Misses                    84143    84143
Impacted Files Coverage Δ
gramps/plugins/docgen/odfdoc.py 12.6% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd6da4...8a6fb7f. Read the comment docs.

@sam-m888 sam-m888 added this to the v5.1 milestone Oct 10, 2019
@sam-m888 sam-m888 merged commit 03ab64c into gramps-project:maintenance/gramps51 Oct 16, 2019
@sam-m888
Copy link
Member

Thank you

@prculley prculley deleted the bug11378 branch October 17, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants