Add support for writing String data into bigqueue #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangalaman93
force-pushed
the
aman/string
branch
from
44df6c0
to
e2a93b3
Compare
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
=========================================
- Coverage 82% 80.8% -1.21%
=========================================
Files 7 7
Lines 289 323 +34
=========================================
+ Hits 237 261 +24
- Misses 27 32 +5
- Partials 25 30 +5
Continue to review full report at Codecov.
|
mangalaman93
force-pushed
the
aman/string
branch
2 times, most recently
from
c3b864b
to
e0991ac
Compare
mangalaman93
force-pushed
the
aman/string
branch
3 times, most recently
from
e532bfe
to
1a14376
Compare
mangalaman93
force-pushed
the
aman/string
branch
from
1a14376
to
9f199f3
Compare
|
@ashish-goswami this is ready to merge now. |
ashish-goswami
approved these changes
Mar 24, 2019
| @@ -45,7 +48,7 @@ func NewBigQueue(dir string, opts ...Option) (*BigQueue, error) { | |||
| } | |||
| defer func() { | |||
| if !complete { | |||
| index.close() | |||
| _ = index.close() | |||
There was a problem hiding this comment.
why are we not checking for errors here?
There was a problem hiding this comment.
Even when we check for errors, the only thing we could do is to log the error. I didn't want to have dependency on log library in bigqueue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19
benchmarks