Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature horizontal illusion line #82

Merged
merged 3 commits into from
Dec 27, 2022

Conversation

Bamboudorer
Copy link
Contributor

No description provided.

@grantjenks
Copy link
Owner

This is a great start! Few things:

  1. Please change the function naming convention to use snake_case rather than camelCase
  2. Would you add a screenshot? I’m curious how the illusion looks.
  3. I’ve approved the check runs. Please address any failures.

@Bamboudorer
Copy link
Contributor Author

Do I use the snake_case for the function and the variables ?

Here is the screenshot :
Screenshot 2022-04-05 214110

I will try my best to address the failures as soon as possible

@grantjenks
Copy link
Owner

That screenshot is great! Love it.

Yes, snake_case for both variable and function names.

@Bamboudorer
Copy link
Contributor Author

I normally manage to fix the flake8 and the isortcheck.

I don't know how to review my code after the bluecheck. Is there a tool to help me to fix it ?

@grantjenks
Copy link
Owner

  1. Install pipx (https://github.com/pypa/pipx)
  2. Install tox like “pipx install tox”
  3. Run “tox -e bluecheck” to see errors
  4. Run “tox -e blue” to reformat the code

@Bamboudorer
Copy link
Contributor Author

Thank you very much.

Normally, it would work.

I will do the same for the battleship game.

@grantjenks grantjenks merged commit 1a3940e into grantjenks:master Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants