Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include regression tests in PyPI tarball #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kmosiejczuk
Copy link

Include regression tests in PyPI tarball for easy regression testing by distributors.

In OpenBSD we use regression tests to make sure nothing has been broken by changes in the main OS or updates of other ports. Having to pull tests from github rather than PyPI makes it harder to do those tests.

@grantjenks
Copy link
Owner

Will this install the tests with the package? I don’t really want that. But if it’s just for distribution (like a tarball) then I suppose that’s fine.

@kmosiejczuk
Copy link
Author

It shouldn't include them in the package. (OpenBSD's package, at least).

@grantjenks
Copy link
Owner

I'm more concerned with whether the tests will be installed with the package from pypi. If someone does "$ pip install sortedcontainers" now does it include the tests? I'd like to avoid that.

@jwilk
Copy link
Contributor

jwilk commented Nov 18, 2019

If someone does "$ pip install sortedcontainers" now does it include the tests?

It doesn't. ☺

@kmosiejczuk
Copy link
Author

The 2.7 tests are failing because your checks are trying to use pytest 5.2.2. pytest dropped Python 2.7 support with 5.0. Pytest 4.6.6 is the most recent that still supports 2.7.

The 3.4 tests are failing because 3.4 doesn't have function typing, so needs to including the typing backport. It's not listed as needed because pytest 5.2.2 requires Python 3.5+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants