Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switched SortedList base class to Sequence #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switched SortedList base class to Sequence #139

wants to merge 1 commit into from

Commits on Jan 17, 2020

  1. Switched SortedList base class to Sequence 

    Since SortedList does not implement the MutableSequence interface (many
of MutableSequence's mixin methods return NotImplemented), it should not
derive from MutableSequence.

This change will allow type checkers to properly reject SortedList as an
argument to a function that takes MutableSequence.

This is a breaking change (albeit a minor one).
    @pganssle
    pganssle committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    4148246 View commit details
    Browse the repository at this point in the history