Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule for E999 #24

Merged
merged 1 commit into from
Jan 19, 2020
Merged

Add rule for E999 #24

merged 1 commit into from
Jan 19, 2020

Conversation

modasserbillah
Copy link
Contributor

@modasserbillah modasserbillah commented Jan 18, 2020 •
edited
Loading

Issue

#8 Missing E999

Solution

Add a rule for E999. This one is broad in scope and doesn't fit the anti-pattern, best practice format for other rules, so I just added an example.

grantmcconnaughey
grantmcconnaughey approved these changes Jan 19, 2020
View reviewed changes
Copy link
Owner

@grantmcconnaughey grantmcconnaughey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Modasser!

@grantmcconnaughey grantmcconnaughey merged commit eb9fd89 into grantmcconnaughey:master Jan 19, 2020
@grantmcconnaughey grantmcconnaughey mentioned this pull request Jan 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantmcconnaughey grantmcconnaughey grantmcconnaughey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@modasserbillah @grantmcconnaughey