Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Responsive Design #18

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Add Responsive Design #18

merged 3 commits into from
Jul 9, 2024

Conversation

grantwforsythe
Copy link
Owner

Pull Request Template

Title

[Provide a succinct and descriptive title for the pull request, e.g., "Improve caching mechanism for API calls"]

Type of Change

  • Feature
  • Fix
  • Refactor
  • UI/UX improvement

Description

[Provide a detailed explanation of the changes you have made. Include the reasons behind these changes and any relevant context. Link any related issues. For UI/UX changes, include a screenshot or recording of the changes.]

Testing

[Detail the testing you have performed to ensure that these changes function as intended. Include information about any added tests.]

Impact

[Discuss the impact of your changes on the project. This might include effects on performance, new dependencies, or changes in behavior.]

Additional Information

[Any additional information that reviewers should be aware of.]

Checklist

  • My code adheres to the coding and style guidelines of the project as specified in CONTRIBUTING.md.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

Copy link

cypress bot commented May 29, 2024

Passing run #8 ↗︎

0 8 0 0 Flakiness 0

Details:

Merge 768346e into e0a29ea...
Project: Default Project Commit: d3d37bbb11 ℹ️
Status: Passed Duration: 00:21 💡
Started: May 29, 2024 1:34 PM Ended: May 29, 2024 1:34 PM

Review all test suite changes for PR #18 ↗︎

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.80%. Comparing base (e0a29ea) to head (768346e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   96.81%   96.80%   -0.02%     
==========================================
  Files          20       20              
  Lines         251      250       -1     
  Branches       20       20              
==========================================
- Hits          243      242       -1     
  Misses          5        5              
  Partials        3        3              
Files Coverage Δ
src/app/login/login.component.ts 100.00% <ø> (ø)
src/app/state/effects/budget-cards.effects.ts 100.00% <ø> (ø)

Copy link

render bot commented May 29, 2024

@grantwforsythe grantwforsythe marked this pull request as ready for review July 9, 2024 22:14
@grantwforsythe grantwforsythe merged commit 9de7dbd into main Jul 9, 2024
8 of 9 checks passed
@grantwforsythe grantwforsythe deleted the feat/add-responsive-styling branch July 9, 2024 22:15
Copy link

cypress bot commented Jul 9, 2024

Passing run #19 ↗︎

0 8 0 0 Flakiness 0

Details:

feat: add responsive design (#18)
Project: Default Project Commit: 9de7dbd491
Status: Passed Duration: 00:09 💡
Started: Jul 9, 2024 10:15 PM Ended: Jul 9, 2024 10:16 PM

Review all test suite changes for PR #18 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant