Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.0 Mig recurring consignment #18

Merged
merged 1 commit into from
May 24, 2020

Conversation

legalsylvain
Copy link
Member

WIP

@legalsylvain legalsylvain marked this pull request as ready for review December 4, 2019 16:55
@coveralls
Copy link

coveralls commented Dec 12, 2019

Pull Request Test Coverage Report for Build 212

  • 241 of 310 (77.74%) changed or added relevant lines in 20 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+5.5%) to 76.56%

Changes Missing Coverage Covered Lines Changed/Added Lines %
recurring_consignment_sale/models/product_template.py 13 14 92.86%
recurring_consignment/models/product_pricelist.py 10 12 83.33%
recurring_consignment/models/product_template.py 12 14 85.71%
recurring_consignment_pos/models/pos_order.py 5 7 71.43%
recurring_consignment_pos/models/product_template.py 15 17 88.24%
recurring_consignment_sale/models/sale_order.py 2 4 50.0%
recurring_consignment/wizards/invoice_commission_wizard.py 53 57 92.98%
recurring_consignment/wizards/invoice_commission_wizard_line.py 55 60 91.67%
recurring_consignment_purchase/models/purchase_order.py 6 11 54.55%
recurring_consignment_purchase/models/purchase_order_line.py 5 10 50.0%
Totals Coverage Status
Change from base Build 211: 5.5%
Covered Lines: 503
Relevant Lines: 657

💛 - Coveralls

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #18 into 12.0 will increase coverage by 7.15%.
The diff coverage is 77.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##             12.0      #18      +/-   ##
==========================================
+ Coverage   71.08%   78.23%   +7.15%     
==========================================
  Files          11       31      +20     
  Lines         166      657     +491     
==========================================
+ Hits          118      514     +396     
- Misses         48      143      +95
Impacted Files Coverage Δ
...curring_consignment/models/account_invoice_line.py 80% <100%> (ø)
recurring_consignment/models/res_partner.py 84.61% <100%> (ø)
recurring_consignment/models/account_move_line.py 100% <100%> (ø)
...nt/models/account_product_fiscal_classification.py 88.88% <100%> (ø)
recurring_consignment/models/account_invoice.py 100% <100%> (ø)
recurring_consignment/models/product_product.py 66.66% <100%> (ø)
recurring_consignment/models/account_tax.py 90% <100%> (ø)
...rring_consignment/models/product_pricelist_item.py 100% <100%> (ø)
...ng_consignment_purchase/models/product_template.py 35.71% <35.71%> (ø)
...ing_consignment/wizards/consignor_create_wizard.py 36.17% <36.17%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa2175c...ee87c9c. Read the comment docs.

@legalsylvain legalsylvain force-pushed the MIG-recurring_consignment branch 2 times, most recently from 85992a5 to d84396e Compare December 17, 2019 09:48
@legalsylvain legalsylvain changed the title Mig recurring consignment 12.0 Mig recurring consignment Dec 20, 2019
@legalsylvain legalsylvain force-pushed the MIG-recurring_consignment branch 3 times, most recently from 540ae1a to 20a4fc8 Compare January 14, 2020 11:24
@legalsylvain
Copy link
Member Author

/ocabot merge patch

@github-grap-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-18-by-legalsylvain-bump-patch, awaiting test results.

@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at 221e89c. Thanks a lot for contributing to grap. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants