Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG] product print category #48

Merged

Conversation

quentinDupont
Copy link
Member

@quentinDupont quentinDupont commented Nov 18, 2019

Testé sur base neuve avec preinstall de sale puis install du module et c'est OK ✔️ en local

@coveralls
Copy link

coveralls commented Nov 20, 2019

Pull Request Test Coverage Report for Build 440

  • 38 of 63 (60.32%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.15%

Changes Missing Coverage Covered Lines Changed/Added Lines %
product_print_category/wizard/product_print_wizard.py 9 16 56.25%
product_print_category/models/product_print_category.py 7 16 43.75%
product_print_category/report/report_pricetag.py 5 14 35.71%
Totals Coverage Status
Change from base Build 438: 0.0%
Covered Lines: 80
Relevant Lines: 133

💛 - Coveralls

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

❗ No coverage uploaded for pull request base (12.0@33d89dd). Click here to learn what that means.
The diff coverage is 55.55%.

Impacted file tree graph

@@           Coverage Diff           @@
##             12.0      #48   +/-   ##
=======================================
  Coverage        ?   57.89%           
=======================================
  Files           ?        6           
  Lines           ?      133           
  Branches        ?        0           
=======================================
  Hits            ?       77           
  Misses          ?       56           
  Partials        ?        0
Impacted Files Coverage Δ
product_print_category/models/res_company.py 100% <100%> (ø)
...print_category/wizard/product_print_wizard_line.py 100% <100%> (ø)
product_print_category/report/report_pricetag.py 26.92% <35.71%> (ø)
...ct_print_category/models/product_print_category.py 54.83% <43.75%> (ø)
...duct_print_category/wizard/product_print_wizard.py 54.76% <56.25%> (ø)
product_print_category/models/product_product.py 80.95% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33d89dd...d2cf3f8. Read the comment docs.

@quentinDupont quentinDupont changed the title [WIP] 12.0 product print category [12.0][MIG] product print category Nov 21, 2019
@legalsylvain
Copy link
Member

/ocabot merge patch

@github-grap-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-48-by-legalsylvain-bump-patch, awaiting test results.

@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at 3aa3c16. Thanks a lot for contributing to grap. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants