Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] product_print_category_food_report (with product_print_category and food modules) #24

Merged
merged 10 commits into from
May 30, 2020

Conversation

quentinDupont
Copy link
Member

/!\ Enlever oca dependencies quand PR product_print_category sera mergé

Modularisation des rapports d'étiquettes.
5 formats d'étiquettes : normal, vrac carré, vrac Applimage, petit carré, comptoir

@quentinDupont quentinDupont changed the title [ADD] Food report with product_print_category [ADD] Food report with product_print_category and food modules Jan 7, 2020
@coveralls
Copy link

coveralls commented Jan 7, 2020

Pull Request Test Coverage Report for Build 206

  • 33 of 73 (45.21%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-7.9%) to 63.18%

Changes Missing Coverage Covered Lines Changed/Added Lines %
product_print_category_food_report/models/product_pricetag_type.py 7 8 87.5%
product_print_category_food_report/models/product_product.py 18 57 31.58%
Totals Coverage Status
Change from base Build 174: -7.9%
Covered Lines: 151
Relevant Lines: 239

💛 - Coveralls

@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #24 into 12.0 will decrease coverage by 0.05%.
The diff coverage is 45.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##             12.0      #24      +/-   ##
==========================================
- Coverage   71.08%   71.03%   -0.06%     
==========================================
  Files          11       63      +52     
  Lines         166     1588    +1422     
==========================================
+ Hits          118     1128    +1010     
- Misses         48      460     +412     
Impacted Files Coverage Δ
...int_category_food_report/models/product_product.py 31.57% <31.57%> (ø)
...tegory_food_report/models/product_pricetag_type.py 87.50% <87.50%> (ø)
...t_print_category_food_report/models/res_company.py 100.00% <100.00%> (ø)
...oduct_print_category_food_report/models/uom_uom.py 100.00% <100.00%> (ø)
product_food/models/certifier_organization.py 100.00% <0.00%> (ø)
product_to_scale_bizerba/models/uom_uom.py 100.00% <0.00%> (ø)
...rring_consignment/models/product_pricelist_item.py 100.00% <0.00%> (ø)
...ock_preparation_category/models/product_product.py 100.00% <0.00%> (ø)
recurring_consignment/models/res_partner.py 56.41% <0.00%> (ø)
...covery_moment/models/sale_recovery_moment_group.py 66.33% <0.00%> (ø)
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7cdefe...6ac87f7. Read the comment docs.

@quentinDupont quentinDupont changed the title [ADD] Food report with product_print_category and food modules [ADD] product_print_category_food_report (with product_print_category and food modules) Apr 27, 2020
Copy link
Member

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pas testé, mais les images ont l'air super !

@legalsylvain
Copy link
Member

/ocabot merge patch

@github-grap-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-24-by-legalsylvain-bump-patch, awaiting test results.

github-grap-bot added a commit that referenced this pull request May 24, 2020
Signed-off-by legalsylvain
@legalsylvain
Copy link
Member

/ocabot merge patch

@github-grap-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-24-by-legalsylvain-bump-patch, awaiting test results.

github-grap-bot added a commit that referenced this pull request May 26, 2020
Signed-off-by legalsylvain
@legalsylvain
Copy link
Member

/ocabot merge patch

@github-grap-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-24-by-legalsylvain-bump-patch, awaiting test results.

github-grap-bot added a commit that referenced this pull request May 27, 2020
Signed-off-by legalsylvain
@github-grap-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-24-by-legalsylvain-bump-patch, awaiting test results.

github-grap-bot added a commit that referenced this pull request May 27, 2020
Signed-off-by legalsylvain
@legalsylvain
Copy link
Member

/ocabot merge patch

@github-grap-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-24-by-legalsylvain-bump-patch, awaiting test results.

@github-grap-bot github-grap-bot merged commit fe5a709 into grap:12.0 May 30, 2020
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at 1cb5ed1. Thanks a lot for contributing to grap. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants