Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install command in travis config #73

Closed
wants to merge 1 commit into from

Conversation

mjq
Copy link
Contributor

@mjq mjq commented Mar 29, 2021

I noticed that my build was failing in #72. I think it's due to the command used in the install step.

From the travis logs:

$ go mod install
go mod install: unknown command

This was probably meant to be go mod download. Hopefully this fixes the build! (Edit: Looks like it did!)

The `go mod install` command does not exist - this was probably meant to
be `go mod download`.
@mjq
Copy link
Contributor Author

mjq commented Mar 30, 2021

Looks like a flaky test in CI maybe? My first push (c3e8926) had a green CI (passed 2/2 checks), my second (6b7905c, identical to the first but committed with the correct email address) failed 1/2 checks.

Edit: I can reproduce this failure, but only rarely - on my laptop, the test failed only 3 out of 10000 runs.

$ go test -v -race -coverprofile=coverage.txt -covermode=atomic -count 10000 | grep FAIL
--- FAIL: TestLoader (0.00s)
    --- FAIL: TestLoader/allows_clearAll_values_in_cache (0.02s)
--- FAIL: TestLoader (0.00s)
    --- FAIL: TestLoader/allows_clearAll_values_in_cache (0.02s)
--- FAIL: TestLoader (0.00s)
    --- FAIL: TestLoader/allows_clearAll_values_in_cache (0.02s)
FAIL
FAIL	github.com/graph-gophers/dataloader/v6	390.973s

@tonyghita
Copy link
Member

@mjq thanks for the pull request. Looks like we got lucky catching the test flake. I'm having a hard time reproducing it but that seems like an issue we'll want to investigate separately.

I haven't been able to reproduce the failure locally yet but I've only been running -count=1000.

I'm not super familiar with TravisCI but I think the default installation mechanism go get ./... works fine so long as we're in module-mode. I've opened a similar PR but with a different approach in #75.

@tonyghita
Copy link
Member

I opened a new issue to track the test flake #76 and merged in #75. Thank you very much for your contribution!

@tonyghita tonyghita closed this Apr 1, 2021
@mjq
Copy link
Contributor Author

mjq commented Apr 1, 2021

Awesome! Thanks for following up on those 👍

@tonyghita
Copy link
Member

@mjq after a bit of digging I've opened #77 to resolve the test flake issue. I'm unable to reproduce the flakiness on my local machine with those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants