Upgrade to Go v1.18 and add support for generics #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 8, 2022
pavelnikolov
force-pushed
the
add-generics-support
branch
from
127cbcc
to
b7b6fed
Compare
|
Sorry I didn't get time to look at this. I'll give it a ride soon. |
agnivade
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
Looks great @pavelnikolov !
I gave it a try here: mattermost/mattermost#19965 and everything looks to be working as expected :) The API looks much cleaner now.
|
Thank you for testing. |
|
I know this was landed a long time ago, but is there any chance you can update the README to illustrate how to use this library now that the API has changed so dramatically (for the better)? The example it has still uses dataloader.Keys, for instance, which I think doesn't exist anymore. |
|
@csilvers PRs would be accepted/appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: