Separate resolvers for queries and mutations #182

sanae10001 · 2018-03-15T06:41:00Z

sanae10001 · 2018-03-15T07:36:46Z

github.com/graph-gophers/graphql-go (download)
github.com/opentracing/opentracing-go (download)
Fetching https://golang.org/x/net/context?go-get=1
Parsing meta tags from https://golang.org/x/net/context?go-get=1 (status code 200)
get "golang.org/x/net/context": found meta tag main.metaImport{Prefix:"golang.org/x/net", VCS:"git", RepoRoot:"https://go.googlesource.com/net"} at https://golang.org/x/net/context?go-get=1
get "golang.org/x/net/context": verifying non-authoritative meta tag
Fetching https://golang.org/x/net?go-get=1
Parsing meta tags from https://golang.org/x/net?go-get=1 (status code 200)
golang.org/x/net (download)
graphql.go:10:2: use of internal package not allowed
graphql.go:11:2: use of internal package not allowed
graphql.go:12:2: use of internal package not allowed
graphql.go:13:2: use of internal package not allowed
graphql.go:14:2: use of internal package not allowed
graphql.go:15:2: use of internal package not allowed
graphql.go:16:2: use of internal package not allowed
internal/exec/exec.go:11:2: use of internal package not allowed
internal/exec/exec.go:12:2: use of internal package not allowed
internal/exec/exec.go:13:2: use of internal package not allowed
internal/exec/exec.go:14:2: use of internal package not allowed
internal/exec/exec.go:15:2: use of internal package not allowed
internal/exec/packer/packer.go:10:2: use of internal package not allowed
internal/exec/packer/packer.go:11:2: use of internal package not allowed
internal/exec/resolvable/meta.go:7:2: use of internal package not allowed
internal/exec/resolvable/resolvable.go:12:2: use of internal package not allowed
internal/exec/resolvable/meta.go:8:2: use of internal package not allowed
internal/exec/selected/selected.go:9:2: use of internal package not allowed
internal/exec/selected/selected.go:10:2: use of internal package not allowed
internal/exec/selected/selected.go:11:2: use of internal package not allowed
internal/exec/selected/selected.go:12:2: use of internal package not allowed
internal/exec/selected/selected.go:13:2: use of internal package not allowed
internal/query/query.go:9:2: use of internal package not allowed
internal/schema/schema.go:9:2: use of internal package not allowed
internal/validation/validation.go:12:2: use of internal package not allowed
internal/validation/validation.go:13:2: use of internal package not allowed
internal/validation/validation.go:14:2: use of internal package not allowed
introspection/introspection.go:6:2: use of internal package not allowed
introspection/introspection.go:7:2: use of internal package not allowed

What happened?

ghostiam · 2018-03-15T14:37:32Z

This change will break compatibility and many people will have to rewrite their code.
I don't want a repeat of the story > satori/go.uuid#66

tonyghita · 2018-03-15T14:58:40Z

@sanae10001 are you still working within $GOPATH/src/github.com/neelance/graphql-go? You probably want to update your working directory.

@GhostRussia there may be some way that we can provide the new functionality without breaking clients (i.e. via some option or some temporary cleverness in the resolver lookup code).

Either way, we'll want to ensure we communicate the changes and impact of the changes before merging this in.

ghostiam · 2018-03-15T21:18:05Z

I think can use the interface to determine the type of resolver.

type Queryer interface {
	Query() interface{}
}

type Mutationer interface {
	Mutation() interface{}
}

And when using interfaces, we do not have to do extra reflection.

rFunc := root.MethodByName("Query")
if !rFunc.IsValid() {
	return nil, errors.New("not found query resolver")
}
 
queryResolver = rFunc.Call(nil)[0]

use:

type RootResolver struct {
}

func (r *Resolver) Query() interface{} {
	return &QueryResolver{}
}

func (r *Resolver) Mutation() interface{} {
	return &MutationResolver{}
}

graphql.MustParseSchema(schema, &RootResolver),

I checked here, this code allows working with two versions of resolvers. Original tests pass, but other tests are needed.

full resolvers patch:
https://gist.github.com/GhostRussia/faa89c113cfca55366ee3867193d4d09#file-0001-separate-resolver-patch

Adapted tests patch:
https://gist.github.com/GhostRussia/faa89c113cfca55366ee3867193d4d09#file-0002-separate-resolver-test-patch

and pass test https://github.com/graph-gophers/graphql-go/pull/182/files#diff-3a3269459d813f994deb0997a653aac2
after change

- func (r *RootResolver) Query() *QueryResolver {
+ func (r *RootResolver) Query() interface{} {
	return &QueryResolver{}
}

- func (r *RootResolver) Mutation() *MutationResolver {
+ func (r *RootResolver) Mutation() interface{} {
	return &MutationResolver{}
}

ghostiam · 2018-03-16T04:39:47Z

#182 (comment)
@tonyghita SemaphoreCI still working within $GOPATH/src/github.com/neelance/graphql-go for PR

tonyghita · 2018-03-16T17:13:00Z

Looks like we had two webhooks to the SemaphoreCI integration that were racing each other. I removed the old one that pointed to the previous repository, so we shouldn't see these issues.

mytototo · 2018-03-23T07:50:20Z

Hi there,

Is there any ETA regarding this PR?
How do you want to handle backward compatibilities?

Thanks a lot for your contribution.

sanae10001 · 2018-04-10T10:43:33Z

@mytototo Now, it don't break compatibility. All above codes can correctly run. Maybe more tests are needed.

mytototo · 2018-04-18T22:05:50Z

@sanae10001 Ok, thanks a lot.

cad · 2018-09-24T07:20:33Z

Any plan on merging this?

mrg0lden · 2018-11-05T19:59:37Z

Do you need any help with this PR to get it merged? @pavelnikolov

pavelnikolov · 2018-11-08T02:40:58Z

I'm trying to respond promptly to all new issues and PRs. I'm sorry for the delay on existing PRs. I'll review shortly.

pavelnikolov · 2018-11-16T02:04:56Z

I wonder if this can be done in a way that doesn't introduce a breaking change 🤔

sanae10001 · 2018-11-16T03:07:03Z

I wonder if this can be done in a way that doesn't introduce a breaking change 🤔

It don't break compatibility. All above codes can correctly run.

mrg0lden · 2018-11-16T09:55:15Z

BTW, what about implementing Go modules? This way we can introduce breaking changes with time when a gain is found.

…

On Fri, Nov 16, 2018, 6:07 AM Yingjie ***@***.***> wrote: I wonder if this can be done in a way that doesn't introduce a breaking change 🤔 It don't break compatibility. All above codes can correctly run. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#182 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AH9dxrjxYgI2R__A584-IDJ5tOO0i1XNks5uvivZgaJpZM4SroNG> .

pavelnikolov · 2018-11-18T05:27:07Z

I wonder if this can be done in a way that doesn't introduce a breaking change 🤔

It don't break compatibility. All above codes can correctly run.

This is not completely true. You had to change the Star Wars example, right? This means that all users of the library will have to do the same when they switch to the latest version. It's not optional. It forces the users to upgrade.

pavelnikolov · 2018-11-18T05:28:58Z

BTW, what about implementing Go modules? This way we can introduce breaking changes with time when a gain is found.

Maybe it's a good idea. This in turn, would also increase complexity. I don't want to introduce something without a clear problem that it solves. This is a very dangerous path that can lead to a lot of unnecessary complexity with very little ROI.

sanae10001 · 2018-11-19T02:44:38Z

@pavelnikolov
Sorry, my mistake.
The changes of Star Wars example only are legacy codes on commit 80ff5e1.
Already restore.

johnmaguire · 2021-10-21T12:57:31Z

@pavelnikolov I'm wondering what the state of this ticket is. As @sanae10001 mentioned, the PR has code to determine if the resolvers are separated or not, and falls back on the existing behavior.

pavelnikolov · 2021-10-21T13:17:55Z

@johnmaguire it is not currently being worked on, as far as I know.

maoueh · 2021-10-21T19:33:54Z

See #421 for a workaround for that, we use this PR in production code, all our resolver's name are prefixed with either Query, Mutation or Subscription.

johnmaguire · 2021-10-21T22:25:41Z

Excuse my ignorance @pavelnikolov but my impression was that this PR was ready for review but has since generated merge conflicts. Is there a reason it wasn't merged in 2018? Would it be merged if it were cleaned up today?

It's worth noting that the gqlgen feature comparsion page points to this issue as a point of distinction for their project.

pavelnikolov · 2023-02-08T22:53:01Z

@sanae10001 I started working on this and will try to add it to the next release. I like your code and I will copy some portion of it.

pavelnikolov · 2023-02-10T00:34:46Z

Closing this in favor of #561

sanae10001 force-pushed the separateresolvers branch from 3ac05e2 to df9ba5a Compare March 15, 2018 06:49

sanae10001 mentioned this pull request Mar 15, 2018

Separate resolvers for queries and mutations #145

Closed

sanae10001 force-pushed the separateresolvers branch from affd1aa to ffadb9b Compare March 26, 2018 07:21

sanae10001 force-pushed the separateresolvers branch from ffadb9b to 8996c33 Compare November 7, 2018 03:56

sanae10001 force-pushed the separateresolvers branch from a34aa17 to e98d8f1 Compare November 19, 2018 02:31

sanae10001 and others added 7 commits November 19, 2018 10:32

Separate resolvers for queries and mutations

80ff5e1

Avoid breaking compatibility

902ed86

refactoring

5b0e733

add legacy tests without starwars tests

4425135

Support subscription

aa25cd7

Add test cases

e6ff8af

Restore starwars example

1e4bb14

sanae10001 force-pushed the separateresolvers branch from e98d8f1 to 1e4bb14 Compare November 19, 2018 02:33

pavelnikolov closed this Feb 10, 2023

pavelnikolov mentioned this pull request Feb 10, 2023

Separate resolvers for each operation #561

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Separate resolvers for queries and mutations #182

Separate resolvers for queries and mutations #182

sanae10001 commented Mar 15, 2018

sanae10001 commented Mar 15, 2018

ghostiam commented Mar 15, 2018

tonyghita commented Mar 15, 2018

ghostiam commented Mar 15, 2018 •

edited

Loading

ghostiam commented Mar 16, 2018 •

edited

Loading

tonyghita commented Mar 16, 2018

mytototo commented Mar 23, 2018

sanae10001 commented Apr 10, 2018 •

edited

Loading

mytototo commented Apr 18, 2018

cad commented Sep 24, 2018

mrg0lden commented Nov 5, 2018

pavelnikolov commented Nov 8, 2018

pavelnikolov commented Nov 16, 2018

sanae10001 commented Nov 16, 2018 •

edited

Loading

mrg0lden commented Nov 16, 2018 via email

pavelnikolov commented Nov 18, 2018

pavelnikolov commented Nov 18, 2018

sanae10001 commented Nov 19, 2018

johnmaguire commented Oct 21, 2021

pavelnikolov commented Oct 21, 2021

maoueh commented Oct 21, 2021

johnmaguire commented Oct 21, 2021

pavelnikolov commented Feb 8, 2023

pavelnikolov commented Feb 10, 2023

Separate resolvers for queries and mutations #182

Separate resolvers for queries and mutations #182

Conversation

sanae10001 commented Mar 15, 2018

sanae10001 commented Mar 15, 2018

ghostiam commented Mar 15, 2018

tonyghita commented Mar 15, 2018

ghostiam commented Mar 15, 2018 • edited Loading

ghostiam commented Mar 16, 2018 • edited Loading

tonyghita commented Mar 16, 2018

mytototo commented Mar 23, 2018

sanae10001 commented Apr 10, 2018 • edited Loading

mytototo commented Apr 18, 2018

cad commented Sep 24, 2018

mrg0lden commented Nov 5, 2018

pavelnikolov commented Nov 8, 2018

pavelnikolov commented Nov 16, 2018

sanae10001 commented Nov 16, 2018 • edited Loading

mrg0lden commented Nov 16, 2018 via email

pavelnikolov commented Nov 18, 2018

pavelnikolov commented Nov 18, 2018

sanae10001 commented Nov 19, 2018

johnmaguire commented Oct 21, 2021

pavelnikolov commented Oct 21, 2021

maoueh commented Oct 21, 2021

johnmaguire commented Oct 21, 2021

pavelnikolov commented Feb 8, 2023

pavelnikolov commented Feb 10, 2023

ghostiam commented Mar 15, 2018 •

edited

Loading

ghostiam commented Mar 16, 2018 •

edited

Loading

sanae10001 commented Apr 10, 2018 •

edited

Loading

sanae10001 commented Nov 16, 2018 •

edited

Loading