Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render accumulation (allow custom background blending) #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jkulhanek
Copy link

This PR enabled accumulation to be rendered and returned.

@ladzin
Copy link

ladzin commented Feb 26, 2024

I tried this fork and it worked great. But I made a mistake: I assumed that gradients with respect to "accumulation" would flow correctly, but that was not the case since backward wasn't implemented -- so I got, silently, the wrong gradients. Would it be helpful to add an error/warning or implement the backward pass?

@aixiaodewugege
Copy link

Thanks for your brilliant work. Does the original version not support a custom background? Is there any document explain it?

@MatteoMarengo
Copy link

Hello !
I had a question, does this fork allows us to start with a customized image and then train the 3DGS with this image as the background ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants