Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant __import__ #177

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Conversation

jxdv
Copy link
Member

@jxdv jxdv commented Dec 31, 2023

Description

There's no need to use import('os').name as we already have imported os - therefore we can just use os.name

Motivation and Context

Less cluttered code + better readability.

How Has This Been Tested?

Ran gX as CLI + Web UI.

Screenshots (if appropriate):

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jxdv
Copy link
Member Author

jxdv commented Dec 31, 2023

I'll create 1 more PR to fix bug when passing invalid addr:port to --web arg after this PR and #176 is merged.

Copy link
Member

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough 👍🏼

@orhun orhun merged commit bcace85 into grapheneX:master Dec 31, 2023
5 checks passed
@jxdv jxdv deleted the remove-import branch December 31, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants