Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for python-dotenv to store secret key #204

Merged
merged 4 commits into from
Jun 22, 2024

Conversation

jxdv
Copy link
Member

@jxdv jxdv commented Jun 15, 2024

Closes #196.

Current workflow:

  • if the .env file doesn't exists then we create it
  • if FLASK_SECRET_KEY is already set and we didn't specify --flask-secret-key then don't touch it
  • if FLASK_SECRET_KEY isn't set and --flask-secret-key isn't set, then use os.urandom to create cryptographically secure key
  • if FLASK_SECRET_KEY is set, but we specified --flask-secret-key then we overwrite it

New changes:

  • added new instructions to README
  • increase size of access token to 12, to make it more secure
  • remove junk from .gitignore, which we never use
  • added python-dotenv dependency to poetry file and also refresh lock file

@jxdv jxdv requested a review from orhun June 15, 2024 14:56
Copy link
Member

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@orhun orhun merged commit bf488b8 into master Jun 22, 2024
7 checks passed
@orhun orhun deleted the feat-secret-key branch June 22, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add support for .env file to safely store secret key
2 participants