-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up GitHub Actions CI #145
Comments
Hi, |
Hey!
We don't really have any tests, I just like to see if the code builds + if there are any lint (PEP?) warnings so yes.
As a start, we can only check the code and the next step would be this. |
I wil try to do this. Can you assign me to the task? In case of any questions I will just write here |
Sure, thanks! |
So, I started building workflow. I encounterd few hardships.
Do you want me to change some settings like max line length or exclude come parts of the code?
|
That ImportError is expected. It is a dependency of some library used in grapheneX. I am still not sure which one it is. You'll find steps how to get rid of that one in: #127 / #121. As for the linter issues, Can you format the output to be more readable? I could create a PR for those, or you can make one yourself. |
Thanks for tips
Tomorrow I will try to get those workarounds for windows and linux. I thought of making it more concise, but with those issues I will see how it will goes.
Unfortunetly, those are logs from github action. Not sure if it can be imported in cleaner way. If I will have some free time I think of making clean and readible table with those issues sorted by the files. I think if I should put it here or create new issue to grab. |
Lists of errors/warnings/etc that Flake8 detected collected by file /graphene/main.py
graphenex/core/cli/commands.py
graphenex/core/cli/help.py
graphenex/core/cli/shell.py
graphenex/core/hrd/init.py
graphenex/core/hrd/exec.py
graphenex/core/utils/helpers.py
graphenex/core/utils/logcl.py
graphenex/core/utils/sysinfo.py
graphenex/core/web/init.py
graphenex/core/web/providers.py
graphenex/core/web/views.py
|
Great, Can you create PR for this, once you fix these issues? @KacperNapierski Please do not remove / move imports in web/init.py otherwise Web UI will stop working:
|
I will take on this after finishing CI workflow. Linux one works and builds automaticaly, but I'm still fighting with automating windows. |
Both linux and windows CI are working now. After linter errors are corrected I will make changes in actions order to linter first and then separate and simultaneous windows and linux builds. Should I PR or first help with #147 and then PR all changes? |
I think you can create 2 separate PRs for fixing the lints and adding the CI workflow. |
This issue can be closed. #149 has been merged 💯 |
Thanks a lot @KacperNapierski @jxd1337 💖 |
Is your feature request related to a problem? Please describe.
It would be nice to check the builds with every push.
Describe the solution you'd like
Create a GitHub Actions workflow file (
.github/workflows/ci.yml
) to check the builds.Describe alternatives you've considered
None.
Additional context
See: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python
The text was updated successfully, but these errors were encountered: