-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI workflow #149
Add CI workflow #149
Conversation
github_CI_workflow
github_CI_workflow
GitHub workflows
github_CI_workflows
GitHub workflows
Hopefully we won't need those workarounds in the future, as we just need to replace some unmaintained libs. See: #135 newest comment. |
That would be great and probably make gX more reliable for all users. If that happens it would be small change for workflow and I will just update it then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, just had some comments/suggestions.
I know @orhun said I can make 2 seperate PRs for linter and CI. My thought process was: if CI will work and check lintering everyone can make linter changes and test them as we progress with fixes |
Sure, makes sense. |
Is this ready for re-review? |
I think so, linux and windows builds with poetry from code from this repository. |
Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
* refactoring * string pep reformat * arg pep reformat * edit doc string * remove unused import * Add CI workflow (#149) Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com> * Format the workflow file * Rename workflow file * refactoring * string pep reformat * arg pep reformat * edit doc string * remove unused import * update exceptions * update commands & web * lint ignore E501 * ignore useless rules * remove whitespaces --------- Co-authored-by: KacperNapierski <80033411+KacperNapierski@users.noreply.github.com> Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
PR is direct response to #145 issue. I've created workflow that test linting and builds graphenex on windows and linux automatically on PR.
Description
The CI.yaml workflow activates when new changes in folders docker and graphenex are PR'ed/pushed into main branch. Workflow can also be started manually with workflow dispatch.
Workflow contains 3 jobs:
Motivation and Context
Help with testing and stigmatization of development pipline
#145
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: