-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bicycle routing support for cycleway:left and cycleway:right tag #280
Comments
Do you mean this for oneway stuff or for changed priority due to the different safety? |
More important is support for the oneway stuff in order to avoid longer detours. If possible priority handling can also be implemented, although it is not easily possible to decide what to prefer for which kind of bike. E.g. a racebike rider probably will not like to go against a oneway. |
Hmmh, the problem is that left and right is country dependent if we want to find out the oneway stuff, right? |
Or is it identical to the :forward and :backward stuff? #205 |
I think that the oneway aspect of this issue (values=opposite*) is identical to #205. After making some overpass queries I found out that the usage of #205 (bicycle:backward) is much more common compared to the cycleway:left or cycleway:right usage with "opposite". I cannot see any country dependent aspect. It does not matter if the car traffic runs on the left or on the right side. Besides the oneway aspect of this issue there is the priority handling aspect, which eventually should be handled differently for every kind of bike. Here I see some relation with one of the aspects of #330, where the highway classification tag, if present, should have some influence on the priorisation. E.g. highway=primary together with some cycleway "lane, track ..." tag should not lead to increased preference, especially when comparing to an ordinary highway=residential or highway=unclassified without any cycleway. The same is true if the cycleway is running opposite to a oneway. We should not prefer such a cycleway. I quickly checked the code, I could not find any part where we are rating down the priority in these cases. I know people, which claim to have statistics, which say that these kind of cycleways are extremly dangerous for a cyclist. I believe that they might be right. |
Okay, my bad, so it is entirely dependent on the 'tagging direction' I've fixed #205, will include bicycle:backward now and handle the prioritization after 0.4 |
Hmmh, according to the wiki the bicycle:backward has a different meaning. |
Maybe you have some direct link with current wrong behaviour? (regarding access restriction) BTW: The cycleway:left/right is not that rare (see here). |
In my last comment I meant that cycleway:left and cycleway:right with the value opposite* are rare, but not that the whole tag is rare. So actually I was quite wrong in my initial comment on this issue, where I meant the opposite stuff is more important compared to the priorisation. With overpass turbo I found this example as testcase: http://www.openstreetmap.org/way/160978261 for a cycleway_left opposite_lane and here is a graphhopper link: You are also completely right when you say that "bicycle:backward" is different to cycleway=opposite*. I was not aware of the strange "bicycle:backward=no" definition: "when a road has a oneway cycleway next to it that must be used, and a cyclelane in the other direction". So in the "no" case there should be an impact on the prioritisation in both directions, and ignore any oneway restriction in the common bicycle encoder. In the bicycle:backward="yes" case only the oneway restriction gets overruled. |
Okay, thanks
Yeah, super strange. But now implemented ;) |
Was this already implemented in some pull request @ratrun ? If not, do you intend to propose one? Otherwise I would postpone this issue ... |
The priority aspect of this issue is still open. I do not intend to make a pull request now, maybe I'll look at it in Winter. I believe that it will be not that easy to get consistent priority handling. |
Ok, thanks! Postponing for now |
Hi, Regards |
Thanks for the reminder. I'm going to provide a simple PR without the priority aspect. The reason is that we are already accepting |
…es for bicycles as discussed in graphhopper#280.
…es for bicycles as discussed in graphhopper#280.
Still not fixed! |
There is a bug with bicycle:forward=use_sidepath, this is considered as one-way. I plan to provide a pull request for this. |
Is this fixed now? |
Yes, I believe that this issue can be closed. |
BikeCommon Flag encoder should add support for the tags "cycleway:left" and "cycleway:right", see http://wiki.openstreetmap.org/wiki/Key:cycleway.
The text was updated successfully, but these errors were encountered: