Remove junit vintage engine, no more JUnit 3/4 #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* @before -> @beforeeach * @after -> @AfterEach * import org.junit.Before; -> import org.junit.jupiter.api.BeforeEach; * import org.junit.After; -> import org.junit.jupiter.api.AfterEach; * import org.junit.Test; -> import org.junit.jupiter.api.Test * commit using 'Reformat Code' and 'Optimize imports'
* import org.junit.BeforeClass -> import org.junit.jupiter.api.BeforeAll * import org.junit.AfterClass -> import org.junit.jupiter.api.AfterAll
* import org.junit.Ignore -> import org.junit.jupiter.api.Disabled
Closed
|
Oh, wow. Really nice - didn't notice this :) 👍 |
|
I saw the earlier thread but just hadn't had time to refresh my memory on JUnit in order to mount a meaningful response, but it seems like you've got it all covered 👍 |
|
Thanks a lot for your initial work on this @Anvoker! Can I add you to the contributors list? |
|
If you think that's enough to warrant it, then sure thing! Don't see why not. |
|
I just saw you are already on the list :) But anyway I updated it here: d141dbd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After replacing
@Theory(#2310) and class-wide parameters (#2312) moving from JUnit 4 to 5 entirely is 'only' a matter of changing the import statements and assertion method calls and I did this here.For a very nice write up and initial work in this direction see #1632.