Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 310: Generated GPX file contains both <rte> and <trk> tags #536

Closed
wants to merge 3 commits into from

Conversation

ratrun
Copy link
Contributor

@ratrun ratrun commented Oct 6, 2015

Launch a popup window in JS where the user can select which GPX data parts shall be exported.
Additionally add the possibility for exporting of GPX waypoints.
Please note that it was necessary to update the jquery-ui version, as otherwise the popup diolog did not show up. I somewhere found the suggestion to update the version on stackoverflow and the updated version works.

Fixes #310

Launch a popup window in JS where the user can select which GPX data parts shall be exported.
Additionally add the possibility for exporting of GPX waypoints.
Please note that it was necessary to update the jquery-ui version, as otherwise the popup diolog did not show up. I somewhere found the suggestion to update the version on stackoverflow and the updated version works.
@karussell
Copy link
Member

👍 nice!

@karussell
Copy link
Member

In the console it says to me: $(...).sortable is not a function and the web UI is scrambled a bit

Is thee a JS-module missing?

Also the translate script should not be modified (in this issue at least :))

@ratrun
Copy link
Contributor Author

ratrun commented Oct 11, 2015

Yes, I'm sorry, one file was missing. Now its added and the change in update-translations.sh reverted.

@karussell
Copy link
Member

Thanks! This is now merged, let me know if this is okay for you!

Note that I've changed the css IDs to avoid collision in the future and also the URL parameters have now a gpx. prefix. Furthermore additionally to FIXME in the source you should add it to the issue text. See the default change for 'route' via #437

@karussell karussell added this to the 0.6 milestone Oct 12, 2015
karussell pushed a commit that referenced this pull request Oct 12, 2015
@karussell
Copy link
Member

deployed, need to document the new parameters

karussell added a commit that referenced this pull request Oct 17, 2015
@karussell karussell closed this Oct 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants