#347 - Custom properties

[balage1541]

I've implemented the request in Vehicle, VehicleType, Location and in the Job classes.
Added some unit tests as well.

I've tried hard to keep formatting, but in some cases it was impossible, so there is some unchanged lines marked as changed.

Still need to migrate this feature to the new branch.

[oblonski]

Great! Thanks.

[carhartl]

Would it make sense to add the setUserData() and getUserData() methods to the job interface? This would allow me to do the following:

Job job = ((TourActivity.JobActivity) tourActivity).getJob();
job.getUserData(); // I may not care about the type of job (service, shipment, ...)

Right now I have to do this:

Job job = (Job) ((TourActivity.JobActivity) tourActivity).getJob();
if (job instanceof Service) {
    ((Service) job).getUserData();
} else if (job instanceof Shipment) {
    ((Shipment) job).getUserData();
}

(There could be a nicer way to do this anyway...)

Alternatively, casting to an abstract (more of internal?) class kind of felt dirty:

AbstractJob job = (AbstractJob) ((TourActivity.JobActivity) tourActivity).getJob();
job.getUserData();

[balage1551]

Thanks, your suggestion makes sense. However, this version of Jsprit is Java7 complient, which means, adding a new method to an interface may break any implementation based on it. (All user defined Job types.)

Jsprit 2 will be built on Java 8, so there we could extend an interface by adding default implementation. Surely we will do it.

As for the current version, you have to take some unconfortable casting for the sake of backward compatibility. By the way, the AbstractJob is not private api, but a minimal base for all job implementation, so don't feel guilty to cast on it!

[carhartl]

Makes sense 👍