Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review TODO/FIXME/etc comments and address some of them #279

Merged
merged 47 commits into from
Apr 17, 2023
Merged

Review TODO/FIXME/etc comments and address some of them #279

merged 47 commits into from
Apr 17, 2023

Commits on Apr 14, 2023

  1. Tidy some TODOs

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    9f6f22e View commit details
    Browse the repository at this point in the history

  2. Rename tableId -> rowDependencyId

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    192e1dd View commit details
    Browse the repository at this point in the history

  3. Remove/action a couple TODOs

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    2555829 View commit details
    Browse the repository at this point in the history

  4. Another JSON overflow test

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    654cb6a View commit details
    Browse the repository at this point in the history

  5. Remove TODO

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    5753448 View commit details
    Browse the repository at this point in the history

  6. Remove PgSelect's asArray - it's not used (and therefore not tested)

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    bf71233 View commit details
    Browse the repository at this point in the history

  7. Clear more TODOs

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    44ff3cc View commit details
    Browse the repository at this point in the history

  8. Rename (internal) RequestContext to RequestTools to avoid ambiguity

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    672e4a9 View commit details
    Browse the repository at this point in the history

  9. Rename copyPlanIds to copyStepIds

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    3558349 View commit details
    Browse the repository at this point in the history

  10. Consistent terminology

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    0d14d48 View commit details
    Browse the repository at this point in the history

  11. Massively out of date comment

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    de3dd95 View commit details
    Browse the repository at this point in the history

  12. Rename grafastGraphql to just grafast

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    53dd0b5 View commit details
    Browse the repository at this point in the history

  13. More TODOs addressed

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    af1afa0 View commit details
    Browse the repository at this point in the history

  14. insideGraphQL can never be true currently

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    56621b6 View commit details
    Browse the repository at this point in the history

  15. No, it is a plan like a field plan is a plan

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    8ef36b4 View commit details
    Browse the repository at this point in the history

  16. Rename __TrackedObjectStep to __TrackedValueStep

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    d7c047b View commit details
    Browse the repository at this point in the history

  17. listPlan -> listStep

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    9f33044 View commit details
    Browse the repository at this point in the history

  18. Rename map() to remapKeys()

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    630ecf0 View commit details
    Browse the repository at this point in the history

  19. Validate payload.data is a string, reformat code

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    dcd933d View commit details
    Browse the repository at this point in the history

  20. Address some minor TODOs

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    78caa1c View commit details
    Browse the repository at this point in the history

  21. PgConnectionArgFirstLastBeforeAfterPlugin -> PgFirstLastBeforeAfterAr… 

    …gsPlugin
    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    a1891ca View commit details
    Browse the repository at this point in the history

  22. Rename pg(Insert|Update|Delete) -> pg(...)Single to make space for fu… 

    …ture bulk ops
    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    bc11588 View commit details
    Browse the repository at this point in the history

  23. Remove a few more TODOs

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    e600665 View commit details
    Browse the repository at this point in the history

  24. Rename orderByNullsLast to pgOrderByNullsLast

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    6cb0827 View commit details
    Browse the repository at this point in the history

  25. Move comment

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    d4bb93c View commit details
    Browse the repository at this point in the history

  26. More unique name for function identifiers

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    010a244 View commit details
    Browse the repository at this point in the history

  27. PERF

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    6fe31b2 View commit details
    Browse the repository at this point in the history

  28. Factor 'field' into field scope names; isPgTableType->isPgClassType

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    3d05962 View commit details
    Browse the repository at this point in the history

  29. Missed this

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    b7fba2d View commit details
    Browse the repository at this point in the history

  30. Oops

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    32fbfaa View commit details
    Browse the repository at this point in the history

  31. Lint fixes

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    71e7632 View commit details
    Browse the repository at this point in the history

  32. Update plan diagrams

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    4665a2d View commit details
    Browse the repository at this point in the history

  33. Schema was reordered again

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    c37a205 View commit details
    Browse the repository at this point in the history

  34. Remove TODOs

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    4805e97 View commit details
    Browse the repository at this point in the history

  35. Consistently remove description from extensions and put on the underl… 

    …ying entities instead
    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    4676240 View commit details
    Browse the repository at this point in the history

  36. Trim whitespace-only descriptions

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    b9fb4da View commit details
    Browse the repository at this point in the history

  37. Relabel TODO

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    f0fd109 View commit details
    Browse the repository at this point in the history

  38. Set enableDeferStream to false (this might break tests...)

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    a0abd35 View commit details
    Browse the repository at this point in the history

  39. Enable stringified tests

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    89c4619 View commit details
    Browse the repository at this point in the history

  40. Lint

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    8aba203 View commit details
    Browse the repository at this point in the history

  41. Fix memory exhaustion on CI?

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    7299ac7 View commit details
    Browse the repository at this point in the history

  42. Re-enable defer/stream for test compatibility

    @benjie
    benjie committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    2f5216c View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Fix find/replace typo

    @benjie
    benjie committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    3c50963 View commit details
    Browse the repository at this point in the history

  2. docs(changeset): description moved out of extensions to live dire… 

    …ctly on all the relevant entities.
    @benjie
    benjie committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    2df36c5 View commit details
    Browse the repository at this point in the history

  3. docs(changeset): listOfCodec type signature changed: all parameters a… 

    …fter the first are now a single config object.
    @benjie
    benjie committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    fbf1da2 View commit details
    Browse the repository at this point in the history

  4. docs(changeset): __TrackedObjectStep is now __TrackedValueStep. `… 

    …MapStep`/`map()` are now `RemapKeysStep`/`remapKeys()`. `ListTransform` now accepts `listStep` rather than `listPlan`.
    @benjie
    benjie committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    0f47093 View commit details
    Browse the repository at this point in the history

  5. docs(changeset): PgConnectionArgFirstLastBeforeAfterPlugin is now `… 

    …PgFirstLastBeforeAfterArgsPlugin` (because it applies to lists as well as connections). `PgInsertStep`/`pgInsert()`/`PgUpdateStep`/`pgUpdate()`/`PgDeleteStep`/`pgDelete()` are now `PgInsertSingleStep`/`pgInsertSingle()`/`PgUpdateSingleStep`/`pgUpdateSingle()`/`PgDeleteSingleStep`/`pgDeleteSingle()` (to make space to add a future bulk API if we want to). `config.schema.orderByNullsLast` is now `config.schema.pgOrderByNullsLast` for consistency (V4 preset users are unaffected). Lots of field scopes in `graphile-build-pg` have been updated to incorporate `field` into their names.
    @benjie
    benjie committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    a73f9c7 View commit details
    Browse the repository at this point in the history