-
-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditional trapping of inhibits; assertion; improve Relay NodeID compatibility #2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s the output plan and the buckets used to produce it to help track down where issues are arising.
…, true)` is no longer supported; instead (and equivalently) please use: `this.addDependency({ step, skipDeduplication: true })`. Note `this.addDependency(step)` (with no additional arguments) is unaffected.
… unary and binary operators.
…an choose to only trap under certain circumstances.
…hout weird results if you pass an incompatible node id (e.g. a 'Post' ID where a 'User' ID was expected) - significantly improves the Relay preset.
🦋 Changeset detectedLatest commit: cf8af9d The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Another PR relating to #2013; follow up to #2015.
For relay we need to be able to support a query like this:
When we do this, what we want changes based on the value of
$authorId
:$authorId
undefined: no condition applied, select all posts (WHERE true
)$authorId
null: find posts which have no author (WHERE author_id is null
)$authorId
validAuthor
ID: find posts by this author (WHERE author_id = $1
)$authorId
is invalid or references the wrong type: raise an error to inform the user of their mistakeIt wasn't possible to do this in plans previously (you had to do it in the step class' execute method instead, like with a resolver) but this PR makes it possible as demonstrated by the changes to
PgNodeIdAttributesPlugin
.Note that
this.addDependency(step, true)
is no longer supported; instead you must usethis.addDependency({ step, skipDeduplication: true })
. I doubt this affects many people.Performance impact
Unknown.
Security impact
None known.
Checklist
yarn lint:fix
passes.yarn test
passes.RELEASE_NOTES.md
file (if one exists).